Author Topic: Side scrolling functionality  (Read 8445 times)

Zefk

  • Hero Member
  • *****
  • Posts: 536
  • Just helping Solarus
    • View Profile
    • Zelzec
Re: Side scrolling functionality
« Reply #30 on: August 08, 2018, 02:40:59 am »
I found a bug when holding down keys.  The hero glides around if I continue to hold the up and right keys at the same time and the hero retains the jump animation if I were to jump while holding the keys.

You can see it near the end of the gif. Ignore the water....I was testing something with a black tile.

Zefk

  • Hero Member
  • *****
  • Posts: 536
  • Just helping Solarus
    • View Profile
    • Zelzec
Re: Side scrolling functionality
« Reply #31 on: August 08, 2018, 08:14:53 am »
Here is a little patch until wrightmat fixes the problem. The hero will not float and get stuck on the jumping animation. Although, it will not prevent the hero from standing still and moving when the right/down or left/down is being pressed at the same time.

Wrightmat's sidescroller script: here
Wrightmat's monster script: here



I think I heard a key on_pressing function was being made. Maybe that could fix the problem.

Patch for game:on_started():
Code: ( lua) [Select]
  function game:on_started()
   local hero = game:get_hero()
    hero:set_tunic_sprite_id("main_heroes/eldran")
    sol.timer.start(gravity, function()
      if self:get_map() ~= nil then
        -- Gravity: move entities down one pixel on every update if there's no collision.
        --   (like with the ground or a platform) and hero not jumping or on a ladder.
        local hero = self:get_hero()
        local x, y, l = hero:get_position()
        if state ~= "jumping" and self:get_map():get_ground(hero:get_position()) ~= "ladder" then
          if not hero:test_obstacles(0, 1) then hero:set_position(x, (y + 1), l) end
        elseif state == "jumping" then
          for i = 1, jump_height do
            if not hero:test_obstacles(0, -1) then hero:set_position(x, (y - 1), l) end
          end
          sol.timer.start(gravity * jump_height, function()
            if self:is_command_pressed("right") or self:is_command_pressed("left") then
              state = "walking"
            else
              state = "stopped"
            end
            --right
            if self:is_command_pressed("right") and self:is_command_pressed("left") then
              hero:set_animation("walking")
              state = "walking"
            else
              state = "stopped"
            end
            if self:is_command_pressed("right") and self:is_command_pressed("up") then
              hero:set_animation("walking")
              state = "walking"
            else
              state = "stopped"
            end
            --left
            if self:is_command_pressed("left") and self:is_command_pressed("right") then
              hero:set_animation("walking")
              state = "walking"
            else
              state = "stopped"
            end
            if self:is_command_pressed("left") and self:is_command_pressed("up") then
              hero:set_animation("walking")
              state = "walking"
            else
              state = "stopped"
            end
            --up
            if self:is_command_pressed("up") and self:is_command_pressed("right") then
              hero:set_animation("walking")
              state = "walking"
            else
              state = "stopped"
            end
            if self:is_command_pressed("up") and self:is_command_pressed("left") then
              hero:set_animation("walking")
              state = "walking"
            else
              state = "stopped"
            end
            if self:is_command_pressed("up") and self:is_command_pressed("down") then
              hero:set_animation("walking")
              state = "walking"
            else
              state = "stopped"
            end
          end)
          hero:set_animation(state)
        end

  function game:on_key_pressed(key)
    local hero = game:get_hero()

    if key == "up" and key == "down" and key == "left" and key == "right"  then
      hero:set_animation("walking")
    else
      hero:set_animation("walking")
    end
  end

Explanation:

I added some checks function game:on_started() to prevent the hero from floating around.

Code: ( lua) [Select]
            --right
            if self:is_command_pressed("right") and self:is_command_pressed("left") then
              hero:set_animation("walking")
              state = "walking"
            else
              state = "stopped"
            end
            if self:is_command_pressed("right") and self:is_command_pressed("up") then
              hero:set_animation("walking")
              state = "walking"
            else
              state = "stopped"
            end
            --left
            if self:is_command_pressed("left") and self:is_command_pressed("right") then
              hero:set_animation("walking")
              state = "walking"
            else
              state = "stopped"
            end
            if self:is_command_pressed("left") and self:is_command_pressed("up") then
              hero:set_animation("walking")
              state = "walking"
            else
              state = "stopped"
            end
            --up
            if self:is_command_pressed("up") and self:is_command_pressed("right") then
              hero:set_animation("walking")
              state = "walking"
            else
              state = "stopped"
            end
            if self:is_command_pressed("up") and self:is_command_pressed("left") then
              hero:set_animation("walking")
              state = "walking"
            else
              state = "stopped"
            end
            if self:is_command_pressed("up") and self:is_command_pressed("down") then
              hero:set_animation("walking")
              state = "walking"
            else
              state = "stopped"
            end

I added this function to prevent the hero from being stuck on the jumping animation.

Code: ( lua) [Select]
  function game:on_key_pressed(key)
    local hero = game:get_hero()

    if key == "up" and key == "down" and key == "left" and key == "right"  then
      hero:set_animation("walking")
    else
      hero:set_animation("walking")
    end
  end

Christopho

  • Administrator
  • Hero Member
  • *****
  • Posts: 1173
    • View Profile
Re: Side scrolling functionality
« Reply #32 on: August 08, 2018, 09:11:43 am »
This is a known issue. The side-scrolling script does not support jumping correctly yet.

Zefk

  • Hero Member
  • *****
  • Posts: 536
  • Just helping Solarus
    • View Profile
    • Zelzec
Re: Side scrolling functionality
« Reply #33 on: August 09, 2018, 01:14:13 am »
@Christopho
Ah, I had no idea.

Updated:
  • Added facing direction option when jumping
  • Added a fix for when the hero gets stuck on a ladder when using the bow
  • Added fixes for sword
  • Added fixes for tapping
  • Added fixes for running
  • Added fixes for lifting
  • Added fixes for water - needs to be converted to dynamic and named water
  • Added fixes for block
  • Added fixes for carrying destructible entities
  • Added fixes for boomerang
  • Added fixes for hookshot
  • Added fixes for opening chest
  • Added fixes for hole or falling
  • Added fake death
  • Added script and comment clean up
  • Added fixes for holding multiple keys when carrying

Download Quest: here




The thing I cannot figure out. The hero jumps faster and faster after every death. The only thing I can think of is to use a fake game:start().

Code: ( lua) [Select]
        local map = game:get_map()
        --Fake death
        --map1
        if game:get_value("map1") == true and map:get_id() == "first_map" then
          if game:get_life() == 1 then
            hero:teleport("first_map", "map1", "fade")
            game:set_life(game:get_max_life())
          end
         --map2
         elseif game:get_value("map2") == true and map:get_id() == "map_leave_test" then
          if game:get_life() == 1 then
            hero:teleport("map_leave_test", "map2", "fade")
            game:set_life(game:get_max_life())
          end
        end


Zefk

  • Hero Member
  • *****
  • Posts: 536
  • Just helping Solarus
    • View Profile
    • Zelzec
Re: Side scrolling functionality
« Reply #34 on: August 11, 2018, 02:13:31 am »
I updated my post and made the side-scroling script somewhat stable: here

It is not perfect, but I could make a side-scroller game with it. I hope it helps someone out there.

Remember to credit Wrightmat because it is his script. I just patched it up.

P.S. I will just silently update the post above if I find bugs.

Ender

  • Newbie
  • *
  • Posts: 1
    • View Profile
Re: Side scrolling functionality
« Reply #35 on: September 03, 2018, 01:45:08 pm »
I can't figure out how to make this run. I put it in my Solarus folder, and it seems have roughly the same contents as the other quests there, but for some reason, the app won't detect it.

Diarandor

  • Hero Member
  • *****
  • Posts: 1046
  • Cats are cool! (ΦωΦ)
    • View Profile
Re: Side scrolling functionality
« Reply #36 on: September 03, 2018, 03:42:17 pm »
A custom feather allowing to jump in sideview maps was done recently, as an improved version of Wrightmat's script. But it will be slightly rewritten again, and using custom states, when Solarus 1.6 (with its custom states) is released.
“If you make people think they're thinking, they'll love you. But if you really make them think, they'll hate you.”