Author Topic: Some Ideas so I Can Help  (Read 82 times)

Cluedrew

  • Newbie
  • *
  • Posts: 2
    • View Profile
Some Ideas so I Can Help
« on: January 05, 2019, 01:52:57 am »
Hello everyone, I've been helping out a bit with some issues. Actually just some issues from GitLab. I am planning on making my own Solarus game, but for now I'm just helping out with the engine. So this year I might just continue to ask for issues, but I have some ideas to for new features/upgrades I could work on and I would like input on how useful/doable these sound.

Template Lua API: I am still learning Solarus, but I know template shenanigans. I am fairly confident I could significantly cut down on the amount of code in the API files. I haven't proven it will work yet but in my sketch of the idea I was able to create universal functions that handled many of the API functions. This could be used to replace many of the existing functions or reduce them to a single line forward if the functions are kept for clarity.

make uninstall: I know basically nothing about this except that it seemed to be missing. But I think being able to clean up for a fresh install would be nice.

Editor Metadata: This one is the biggest jump. Create a space/more space for project data that is not part of the final game. Might even go in a "meta/" or "editor/" directory beside "data/". Many I ideas I've had so far might be handled elsewhere (entities and enemies are pretty forced so stamps/prefabs aren't as useful). The one I am pretty sure hasn't been covered is multiple start scripts, only one is in the actually game but you have others for debugging & testing. Maybe some more editor configuration options would be good.

I just remembered the other crazy idea I had here, but it was some editor hooks for entities that the editor could call to help with editing. The motivating example was jumpers, the distance they sent the hero was set in a pop-up as a number. I would love to be able somehow click and drag that on the map view but that would require... I'm not sure what yet.

And that is what I have so far. The first I am pretty confident in if people want it done. Others not so much but I thought I would run them by people. And if none of them work I will ponder more ideas and take some issues in the mean time.

Diarandor

  • Hero Member
  • *****
  • Posts: 1035
  • Cats are cool! (ΦωΦ)
    • View Profile
Re: Some Ideas so I Can Help
« Reply #1 on: January 05, 2019, 09:40:00 am »
About the jumpers, you can open an issue to allow resizing jumpers, so that the jumpers width that you see in the Editor corresponds with their jumping distance of the jumper properties. Also, the jumpers could be shown as semitransparent, to allow seing what is below. Another option is to enlarge the jumper in that way only when the cursor is moved above the jumper. I thought that there was an issue for this, but I cannot find it.
« Last Edit: January 05, 2019, 09:43:08 am by Diarandor »
“If you make people think they're thinking, they'll love you. But if you really make them think, they'll hate you.”

Neovyse

  • Administrator
  • Full Member
  • *****
  • Posts: 138
    • View Profile
Re: Some Ideas so I Can Help
« Reply #2 on: January 05, 2019, 10:49:44 am »
You can fork the projects on Gitlab and make your modifications, and then make a merge request.

alexgleason

  • Full Member
  • ***
  • Posts: 102
  • Vegan on a Desert Island
    • View Profile
    • Vegan on a Desert Island
Re: Some Ideas so I Can Help
« Reply #3 on: January 05, 2019, 06:31:47 pm »
I opened the `make uninstall` issue. The reason I opened it is because I was trying to compile solarus-snap and I realized my system was pulling in resources from my local `make install`ed version of Solarus 1.6, so I couldn't verify that my Snap would actually build in a fresh machine.

The better way of solving this problem would probably be to fix solarus-snap#17. I could use help with this. I'm also quite tempted to finish making solarus-flatpak work instead because it shouldn't have this type of issue (but also has its own set of downsides).
RIP Aaron Swartz

Cluedrew

  • Newbie
  • *
  • Posts: 2
    • View Profile
Re: Some Ideas so I Can Help
« Reply #4 on: January 05, 2019, 09:06:25 pm »
To alexgleason: I figured that might be the use case. I think I will do the make uninstall because I have momentum, I've found a section of the CMake FAQ that talks about how to do it and it should make testing easier in the future for any install method as well.

Not that I particularly enjoy working with CMake, it is UGLY.

On Feedback: I'm also looking for info about how useful some of these ideas would be. For instance is a one off fix for jumpers enough or are there other types of entities that could benefit from some common ground work? Would be reducing the code in the Lua API files be a good addition? I haven't been around long enough to know, so maybe I'm being excessive, it wouldn't be the first time.